Generally agree with most of the stuff here, I will just add my two cents.
Warlock melee pet damage scaling is in general very bad in comparison to Hunters due to less damage / AP bonus modifiers when compared to Hunters but also any party / raid AP buff that is applied to hunter is gonna be partially transferred to the pet because Hunter shares percentage of his AP with his pet while the pet is gonna be directly affected by those buffs as well (except world buffs) so they are kind of double dipping. On the other side Warlock pets scale with his / hers SP, and the only SP party buffs comes from the warlock (demonic pact) so you end up in situation where Warlock in melee party does not double dip his Felguard / Succubus because AP buff on lock does nothing to the pet or you provide your party with demonic pact which really impacts only imp (it gives your melee pet some +7-8 dmg per hit due to increase to your SP) and then you probably end up in caster party where your melee pet does not get majority of the AP buffs. Solution - as mentioned before either buff unholy power directly or give it also bonus to AP scaling from Warlocks SP.
Felguard - as mentioned above, more scaling with demo tree. Maybe make him get bonus attack speed from imroved subjugate demon, or make him proc fire stone effect when you take improved firestone talent, make him unlock demonic frenzy (stacking AP bonus with every hit) and or felstorm when you take some high level demo talent (soul link, master demo, sacrifice etc).
Metamorphosis scaling with demo tree - bonus health from fel stamina talent, reduction of mana cost from master summoner, reduction of CC or at least banish duration from imroved subjugate demon, ap scaling from locks SP with uholy power, etc .
Everlasting affliction - corruption should be also applied by all variants of shadowbolt (volley, shadow cleave) not just refreshed. That would give decent buff to affli and demo, mostly in AOE situation.
Invocation - just make it proc at least for half the effect every time you recast the dot on the target regardless of remaining duration, again would buff affli and demo and would synergize very nicely with Everlasting Affliction.
Vengeance - maybe give huge buff to damage to both Warlock and his pet when activated while soul link is active (and maybe huge buff to threat or damage while Meta is active)
Meme abilities and talents:
Drain mana - too slow mana drain given how bursty SOD is. Maybe make master channeler apply to drain mana but only for 5 seconds and give it 15 sec CD?
Improved drain mana talent (15/30% of mana drained causes damage) - this equals to 15-30 DPS at lvl 50 with ability that needs to be channeled. Maybe if it dealt 100/200% of mana drained as damage it would be note worthy.
All talents that incrase only base damage instead of total damage of individual spell - amplify curse, imroved curse of corruption, improved immolate pretty much every talent that has specific spell name in it - these need to scale with damage from SP / AP (regardless of class) as well not just base damage.
Abilities that do not scale with gear at all - for example Curse of Weakness bosses and players hit for 1K plus before any reduction is applied and this spell reduces raw damage by 22 at lvl 50. What is the point of this spell in real situation when you can either cast CoS, CoE, CoA or CoR instead all of which either scale directly or indirectly?
Fire Stone, Spell Stone and their respective talents. This conjured items are clunky to use (off hand item), Spell Stone is one use, so you have to switch to other off hand item when you use it but if you want to use mid fight you need start the fight with it because when you equip it it has 30 sec CD, it absorbs only whopping 650 spell damage at lvl 50. There is a capstone talent (yes demo lock has 2 final talents, other one is Soul Link that is disabled in metamorphosis) that increases absorbed damage by 15/30%… The talent need to make it multiple use item with 60 sec CD and increase the effectivness by at least 100% of not more to be at least bit relevant.
Fire Stone - make the proc damage scale with locks spellpower (currently it procs for 60-90 fire damage roughly every 6th autoattack at lvl 50), maybe make it proc from felguards attacks when the fire stone is equipped by warlock (or maybe bind it to the talent).
Improved Fire Stone talent - another high level talent that does effectivelly nothing, +15/30% to the effect of firestone (so +5 fire SP and +18-27 damage to the proc at level 50). Make it proc from dots and Felguard autoattacks for 50/100 % of the proc damage on top of the current bonuses.
Improved Subjugate Demon - this is so extremely niche and at the same time it is very high level talent, it should increase duration of subjugation on top of reducing the debuff to make infernal and doomguard better with demo talents, maybe even cause some direct buff to inferno and doom like reduction of CD, number of participants for ritual, scaling of these pets with demo talents etc. Or if we are feeling spicy maybe buff to Felguard like increase to attack speed, felstorm with 5 points put into this talents, maybe give Warlock ability to equip his Felguard with 2 handed weapon.
Soul Link - if the damage transfer while in meta is too much give it some alternative effect. Like double effect of master demonologist, or all the “demo” runes or threat transfer from pet. It is rediculous that final talent of the “tanking” talent tree is disabled with tanking rune.