Discussing about this is pointless because people mostly take the faction that attracts them the most lore wise etc, the difference is so minor that it doesn’t even matter what you pick. I will run some simulators later on since I got a Scryers mage and an Aldor mage 70.
For pvp definitly pick Scryers as mage because crit rating is far superior over raw spell power. As Warlock however pick Aldor because you don’t need crit rating as affliction lock.
For pve I would still go Scryers. For example if 1 Fireball/Incinerate/Shadow Bolt crit hits for about 3k damage on average(probably more) which makes it 30 damage/1% crit=30SP because 1:1 scaling. 1% crit = 22.1 crit rating. 5 crit rating is aprox 0.22% crit. if 1% crit is 30 SP 0.22% crit is about 6.6 SP. This is simple math.
The further in game the less important crit rating will be, similators show that the more crit is stacked the less SP it’s worth. Early game it’s however the other side around Crit is rated far higher than SP, This is because of ignite stacking and Ruin. Mages have to keep up their own Ignites now, back in vanilla classic this wasnt the case. Warlocks & Arcane Mages also got crit scale 100%.
Early game Scryers is definitly better because crit > raw SP.
For PVP scryers is definitly better.
If we compare the Nax enchant. -3SP Scryers vs +3SP Aldor While Aldor has -4 Crit rating and Scryers +1 Crit rating. Do the math here yourself lol. I got no clue where u got this information from but +3SP and -4Crit rating is far worse than -3SP and +1Crit Rating. So Scryers would dominate here. To be fair I wouldn’t even Run nax anymore for -1Crit rating and +3SP Because its Basically the same thing as Scryers.
Late game Aldor might be superior this is when Sunwell comes around the corner but I doubt because of gem stacking and superior gear this would matter at all. Also this far into the game WOTLK comes around the corner and TBC is almost to his end.
Destro Warlock=Scryers, Affliction Warlock=Aldor
Mages=Scryers
Shadow Priest=Aldor
All the current statistics are irrelevant because they are mostly harvested out of PTRs, or Vanilla Classic.