As a sub rogue:
Single-Target Stat Priority
The general single-target stat priority for a Subtlety Rogue is:
- Critical Strike;
- Versatility;
- Mastery;
- Haste.
On single-target, all four stats are very close to each other. If you do not have access to 
The First Dance, Haste becomes your best stat.
Multi-Target Stat Priority
The general multi-target stat priority for a Subtlety Rogue is:
- Mastery;
- Critical Strike;
- Versatility;
- Haste.
For PvP
- Mastery
- Vers
Traits
Inner Ring
The Inner Ring consists mostly of defensive or utility traits.
Longstrider is arguably the best “DPS” option in this tier. By increasing your movement speed, it allows you to close gaps and dodge things slightly faster.
Resounding Protection is an absorb shield that automatically gets applied every 30 seconds. This is one of the best defensive traits to have, as you will always be able to benefit from it.
Azerite Trait Rotation Changes and Details for Subtlety Rogue
Some of your Azerite Traits in BFA can have a small effect on your rotation (more so in the prepatch).
-
Night’s Vengeance gives you a buff for 8 seconds after casting 
Rupture, which increases the damage done of your next 
Eviscerate. Due to the short duration of the buff, you want to make sure you refresh Rupture just before entering 
Shadow Dance to stack all damage multipliers for maximum DPS gain. In AoE situations, make sure to alter between Rupture and Eviscerate to get maximum benefit from the trait.
-
Perforate causes your Backstab to give you a buff which increases the damage done of your next Backstabs for 12 seconds, stacking up to 3 times. Keeping this buff up is not going to require too much attention, but aim to refresh it before you enter Shadow Dance. Do not worry about it too much, because it is a very marginal gain.
-
The First Dance alters your Shadow Dance rotation slightly due to the Combo Points it gives upon activating Shadow Dance. You will often end up with 5+ Combo Points after your first
Shadowstrike, which means that you should use a finisher instead.
For PvP
Outer Rings
Below are the best Outer Ring traits.
-
Night’s Vengeance
-
The First Dance
-
Heart of Darkness (Now gives you stat anyway)
-
Inevitability
-
Blade In The Shadows
Subtlety Rogues do not depend on one single trait to increase their damage. Instead, they want a mix of the above traits. Because most of your damage is increased by your Mastery, you want to maximize the damage of your Eviscerates. This means Night’s Vengeance will give you the most burst and sustained damage. You want at least one The First Dance for the stat increase and the Combo Points that are generated. Blade In The Shadows and Inevitability both increase your overall damage output and work well with the above traits. If your Corruption Level is 25 or higher, Heart of Darkness provides a great boost to your secondary stats.
Middle Ring
Below are the best Middle Ring traits.
-
Heed My Call
-
Earthlink
-
Overwhelming Power (Personal favorite)
-
Elemental Whirl
The Middle and Inner rings are important for additional damage. Elemental Whirl, Overwhelming Power, and Earthlink give an increase to your stats. These are minor stat boosts, but still increase your damage. Heed My Call will help increase your single target pressure.
Inner Ring
Below are the best Inner Ring traits.
-
Resounding Protection
-
Shrouded Mantle
-
Impassive Visage
Essences
Raid
Worldvein Resonance (Major: 
Worldvein Resonance / Minor: Lifeblood) is the best single-target essence
Minor
-
The Crucible of Flame (
Ancient Flame) is strong on pure single-target due to high DPS output. (Broken dmg in the prepatch)
-
Memory of Lucid Dreams (
Memory of Lucid Dreams) is the highest DPS minor essence on both single target and AoE due to increased resource gain.
-
Conflict and Strife (
Strife) is solid for both single-target and AoE. (You could also use Blood of the enemy)
Dungeons
In dungeons i change the major. I use mostly Blood of the enemy and Reaping flame due to being broken in the prepatch.
PVP
- Reaping in bg (due to being broken), would also use it in arena if you dont have the drest trinket. If you got the drest trinket you could also use blood of the enemy and combo it for huge dmg.
Minor: Conflict, lucid and crusible.
