I feel like all rogue specs should’ve cdr on vanish, not just outlaw.
It makes Subterfuge section for Sub rogue useless in PvP/PvE and makes all other talents regarding vanish bad aswell, for Assa you still play it in PvP because its just too bad, not to play for Discrimminate Carnage but in turn favors Nightelve racial tremendously otherwise its trolling. On the other hand for outlaw it became the new Shadowdance burst window while its mandatory to take Subterfuge for BtE spamm.
Thoughts: neither Assa nor Outlaw should have any noticeable combat benefits from Vanish. It should go back to being a defensive cooldown, especially in PvE.
The fact that Outlaw, the spec ostensibly the most about being in-your-face and direct, benefits the most from Vanish (losing up to 15-20% damage when not using it properly), speaks a lot about a total disconnect between the spec fantasy and actual gameplay.
Assa is a bit better, but also benefits from Vanish enough for double Vanish talent builds to be the default in M+ (thankfully, raid is a different matter).
Sub is ironically the spec that cares the least about Vanish, because SD exists and triggers the most relevant benefits while being way more accessible than Vanish. There’s some disconnect here too, but I’m not sure what can be done about it.
TL;DR: No CDR for Vanish, rework Assa/Outlaw Rogue to not care about Vanish as an offensive tool outside of PvP (where it has always been a Swiss knife allowing you to reposition and choose your next move). In PvE, Vanish should not be a button you want to use on cooldown in either M+ or raid environments.
Stealth being required for offense for Assa/Outlaw is imo the worst design decision they have done for rogues in some time. Giving every rogue spec Dance, utilising that in their offensive play and then removing it so you are now even more required to play meld is beyond stupid. Assa right now has a pretty decent design for shuffle but I still hate it (and well, I don’t play shuffle so).