Just going in for looks really.
Dwarf seems like helmets don’t suit em and in my mind must go Maces and axes because that’s iconic to dwarves.
On the plus side they looks stocky and robust, a little tank in plate.
Kul tiran are large and stocky suits swords axes and Maces.
Problem I have is their belly, it looks ridiculous in a few sets, as in it’s a fat superhero trying on their costume way past their prime.
Kul’Tiran female warrior is best warrior
Don’t shame what I do at home!
Agreed that this combo looks great.
Pandaren!
When in doubt its a pandaren!
Though seriously, pandaren got the best animations.
Between these two options I’d personally go for Dwarf.
I find KT are as challenging to get a good mog on (for plate) as Pandaren, but you just have to find something that works.
KulTirans looks cool in plate armor with huge shoulder pads. You hardly even notice their belly if they’re covered in so much metal.
Funny enough back in Legion I had a Pandaren warrior. Got all mage tower appearances for warrior on him.
I deleted him and moved realm 
Animations are top notch 
Recover him <.<
It’s too cultured for me, must have certain style of swords, or monk like staff.
Dwarf and kul tiran were a little more generic, that’s why I wanted change.
Dwarf Warriors have the whole Mountain King lore going for them, whereas Kul Tirans are a little more bland in the context of race attachment.
For me, when I’m playing a warrior, I prefer to play one that nobody tosses.
Dwarf heritage armor looks fantastic on warriors, if that matters to you.
Class trial them and check who have more appealing animations if you cant decide 
My first thought was:
Female? Kultiran!
Male? Dwarf!
One of reasons why I would make Frost DK if I would want to play Dwarf. Warriors tho~
Warriors are kinda neutral and:
Two of my favourite races…hard to choose. Maybe for a warrior I would go with Kul Tiran.
You can also check Covenant abilities and theme~ then pick race based on most fitting choice.
Kultiran fits Night Fae (Drust will be there to my knowledge~ dont know if friendly or hostile) where Dwarf would probably go for~ Bastion? I am not sure… But its something to consider 
Gnome is the obvious warrior choice, looks great in any mog, the forum picture maybe not so much.
Ok, after seeing that I won’t complain that my forum portrait isn’t centered anymore. 
It’s all true!