Right now, warlock tank has very poor mitigation in comparison to other tanks, to the point where you want to avoid tanking some bosses in BWL until you have either BIS gear or until your raid group clears the content very fast (which means you are not a good tank for progress). Especially the health is much lower than on other tanks and only mitigation (dodge) feels kind of buggy the way it is implemented right now.
Short version: fix / tweak Dance of the Wicked rune, give Metaform some buffs to hp, dodge and or defense from the talents in the demo tree.
At the same time you have some weird interactions with the talent tree as a tank.
Demonology tree gives you your two main survivability talents; Demonic Embrace a first talent (that gives +15% stamina and -5% spirit) and Master Demonologist a second to last talent (+threat, +physical dmg reduction, +all resist +damage done as long as Felguard is active). However there is nothing in between for you as a tank. Soul link is disabled and spellstone is useless given how clunky and weak it is in comparison to damage we normally receive both in PVP and as a tank.
Destruction tree gives you Devastation (+5% crit with destro spells), which does not count towards bonus dodge gained from Dance of the Wicked (DOTW) rune, Improved Searing Pain (+10% crit with that spell) again does not count towards DOTW.
Only your current spell crit from your int, gear and buffs counts towards the bonus dodge. If dot has snapshotted bonus spell crit chance, DOTW will get triggered and reapplied more often but it will not provide you with bonus dodge from the snapshotted crit chance, instead it will actually overwrite previous supprior version fo the buff.
Possible Solution(s), just some of them would be enough:
- Fel Stamina in demo tree should increase max health in metamorphosis just like it increases max health of pet (similiar to how dire bear works).
- Fel Intellect in demo tree should give you dodge scaling with intellect on top of agility (which is very low on warlock) while in metamorphosis.
- Unholy power in demo tree (gives pet +20% damage) should increase either damage (to counter the recent nerf if you go deep into demo tree), or even better defense while in Metamorphosis.
- Demonic Sacrifice and or Improved Subjugate Demon could unlock parry and give you some bonus parry while in Metamorphosis.
- Improved Spellstone and or Soul Link could give you ability to “parry spells” / spell reflect with weapon. It would work similiar to how that passive part of ZG flask works, so like parry (or maybe block) works vs melee attacks. Would scale with intellect and defense.
- Make DOTW work with snapshotted spell crit and spell specific crit, make it not get overwritten by inferior buff unless less than 5 seconds of buff is remaining.