The original name of “Combat” for the Spec was extremely lazy. This game is a combat game, with some other stuff in it, but mainly everything we do revolves around being in combat. The name itself offers no way of providing an identity or style to the Spec. “Outlaw” was a fitting name, and while one might argue it leaned a bit too hard on the Pirate theme specifically, it is rather fitting in the context of Warcraft. They could’ve gone with more of a Highwayman style as well, but the main idea of being a criminal, who is all about the money, not too bothered how they get it, that worked out pretty well.
I think if they ever did some Glyphs for the Class, some Rogue specific Transmog, that could help with selling the fantasy better. Hopefully the new Talents allow for enough flexibility to allow us to be the kind of Outlaw we want to be.
The Samurai were the elite class of warriors. Ideally, they would be closer to Paladins, but in reality, depending on the period, they could’ve just been bored nobles playing with swords. A Ronin would be a Samurai without a master. Even then, they wouldn’t be a roguish character, but instead closer to a wandering Knight, so Warrior and Paladin would be the closest analogues for both Samurai and Ronin.
The Ninja, or Shinobi, would be the closest thing to a Rogue. They were Assassins, Intelligence Agents. They would commit sabotage, spy on their targets, and use stealth, disguises and subterfuge to get past guards in order to assassinate their marks. Their weapons were often poisons, and small blades, concealed weapons. In Warcraft, we see both Assassination and Subtlety fit this fantasy pretty well.
_
Honestly, the one thing WoW Rogues don’t have in their kit is the ability to sabotage, which translated to game mechanics would be something like traps and explosives. Using smoke bombs and firecrackers to distract, stuff like that would feel fitting as well. A good place for Aesthetic Glyphs to modify existing Spells, like Distract and Smoke Bomb.