Considering that when the writers state that there’s an “x” race “x” class, then it’s considered lore, it’s probably best to simply rephrase by asking you, what race do you find befitting of a certain class the most and perhaps going even further, by linking a specific sub-class to a race.
For instance, as a Horde player, I always felt that an Undead Affliction Warlock, an Orc Demonology Warlock and a Blood Elf Destruction Warlock would make the most sense. But I’ve only ever thought about this with the Warlock and none of the other classes, as I’m not really that acquainted with them.
Would be interesting to read your opinions on how you perceive (sub)class race combinations to be the most fitting in your mind.
Hunter : Night Elf and Dwarf seems most iconic to me. But in truth all classes suit it.
Druid: Night Elves suit them perfectly.
Mage: Humans and Night elves.
Shaman: Orcs.
Warrior: Orcs, Broxigar the red come to mind as one of the bravest and boldest.
Warlock: Orcs and Blood Elves.
Monk: Pandaren all the way.
Paladin: That would be humans.
Death Knight: Humans once more, but they also suit the Forsaken.
Rogue: Humans, but I also love Goblin rogues. And of course Night Elven ones.
Demon Hunters: Should be Night Elf only in my view.
I get that Night Elves can be mages nowadays but considering arcane magic was banned for ten thousand years, I don’t think they would be the best representative for ‘true to the lore’. Naga/Highborne/Nightborne suits a lot better imo.