Generally, anything that is inside is/can be bad and everything outside is fine. Because when you are dealing with close quarters your camera can happen to weird angle where you can’t see anything.
I have always felt I like SotS, because it is outside and the packs have enough space to play with, but the 2nd boss is such bs. Sometimes on melee boss
you can’t tell which way he is pointing and if he lands his shot on you, it can one shot you.
Worst:
I hate many ones like Dire Maul, but I would not say it’s the worst. Whenever leveling a alt I would hate it when this dungeon comes up. The usual 3 or 5 wipes with the tank leaving. And lots and lots of walking.
I need to Really think about what’s the worst and then come back and edit my comment later.
Best:
I love the Zul Aman and Zul Gurub ones
Best
Vanilla- Scarlet Monastery - Blackrock Depths
TBC- Slave Pens, Hellfire Ramparts
WotLK- Halls of Reflection
Cata- None
MoP- Stormstout Brewery
WoD- Iron Docks
Legion- Court of the Stars
BfA- Both Mechagon
Worst
Vanilla- Lower Blackrock Spire
TBC- Alcatraz
WotLK- Occulus and Iron Dwarf Dungeons
Cata- I hate all but updated SM is the worst for ruining the original. (Rest in Peace Herod, you will always be the real Scarlet Champion)
MoP- All of them except Stormstout
WoD- Everbloom -Blackrock Caverns
Legion- Dalaran Prisonbeak vol 2.
BfA- King’s Rest
I despise every single legion dungeon and Junkyard.
I very much like Underrot, SoB and Motherlode though.
Best dungeon ever imo is grimrail depot and the worst are too many to choose from. I’d say at least all classic and tbc dungeons sucks, and wotlk wasn’t much better. WoD dungeons rocked except bloodmaul slag mines. M+ is the worst, I never play them, I play to relax and have a good time and not to stress myself out completely by racing a timer and annoying affixes all the while listening to someone yelling at the rest of us, no thanks.
With pugs:
Best = Freehold
Worst = Shrine of the Storm
With team
Best=Freehold
Worst=Siege of boralus
Worst: Tol Dagor because i hate gimmicky dungeons and it doesn’t really help that the whole dungeon is a buggy mess since launch.
Best: Freehold.
Best: Magisters Terrace
Worst: Dire Maul
Best: Workshop.
Worst: Tol dagor.
The best dungeon in the history of WoW is without doubt Blackrock Depths. That one is larger than most raids, it has more trash and bosses and there are quite a few quests related to it.
The worst dungeon to me is End Time, which is really dull.
This one looks so awsome.
best: Kara
worst: everything else
Fav: Shrine of the Storms, Waycrest Manor
Worst: Siege of Boralus, Tol’Dagor
All time fav: Auchindoun from WOD / Magister’s Terrace
Best dungeons: Karazhan Upper, Maw of Souls, Freehold, King’s Rest, Court of Stars
WORST: SotT, Siege of Boralus, Mechagon Junkyard, Shrine of the Storm, Lower Karazhan, Tol’ Dagor
This expansion;
Best dungeon: Underrot
Worst:Tol Dagor
Looks like they’re going back to Karazhan raid / dungeon style, which is awesome because Kara was brilliant.
Best: Waycrest Manor
Worst: Tol Dagor
Overall
Best : BRD (dem feels)
Worst : CoS
Best:
Worst:
Howwwww, that dungeon was awesome 
HOGGER