Today? Today is better than Legion.
We actually got some spells back in Shadowlands, for all its flaws.
BFA was objectively worse because it removed even more spells after Legion, added GCDs to everything, and forced PvP players to get PvE gear and grind AP. I actually skipped the whole thing.
But again, Legion started all of this. Legion removed PvP vendors, Legion pruned 30% of the spellbook, Legion introduced AP into the game.
To read more: Legion was a McDonald's meal