I am a rogue and having a great time. Doing PvE this time in Classic. I was a rogue in Vanilla too for quite a while, there I did the PvP thing, and was awesome too.
The biggest problem is, you cant excel in both without respeccing constantly and building two gear sets. When you set for PvE, you will be average in PvP, and the other way around.
In PvE spec and well geared, you are quite the powerhouse and among the top DPS. Some encounters are more suited than others, but the same is for every class really.
Those saying you only get to hit two buttons is a bit short sighted. Yes you spam the combo building attack the most, but what class does not have a main attack they press most? And if you do not care to be best you can, then yeah, two or three buttons is enough and its boring and you will probably get kicked out the raid guild for being a slacker.
Its a fun game of deciding what cooldown to pop when, when to go for a finisher like Eviscerate, or when its more efficient to spend those points to refresh your Slice & Dice. Pop your Blade Flurry now, or wait for next encounter, cause there will be a second in attack range = extra DPS. And so on. Also sometimes your utility in CC is needed. Specially in dungeons this is the case. And being PvE you can farm mobs quite easy for income.
PvP in the right spec and gear is great fun. Not too efficient in large battles, because AoE rocks there and you are pulled out of stealth constantly, and hardly have 1 on 1 encounters. But in wPvP, WSG and AB you can perform really well. In AV also if you focus on objectives too.
Being deep specced in PvP might make it hard to farm mobs for gold, but thereās always BRD pickpocket runs, where the extra stealth talents are a big plus, and can net you as easy gold as other classes do farming mobs or dungeons. It is boring, but what gold farm is not.