Believe it or not, this is what I picked
For my hunter - Blood elf , I just felt that the ranger identity was strongest on the blood elf over the night elf. Sure night elves have huntresses, and we’ve got strong identities of that, although its a bit confused - i suspect half the players feel night elves are paficists and vegans - but never bother to think why their druids would turn into cats or hunting has such a strong identity with them. Some of the classic quests had you hunting animals for food and furs adn the thrill of the kill - though not in a wasteful sense, you did it for a purpose, but enjoyed the kill - not very pacifist or treehugger vegan.
I just felt the Thalassian elf ranger identity was more powerful - we have Alleria, Sylvanas, Vereesa, all famous characters as rangers, Lor’themar, Halduron Brightwing, the sunwell trilogy while focused on Anveena, has the majority of its Thalassian characters as rangers.
The blood elf starting zone too. Yes there is the magic thing there, but equally strong is the Farstrider enclave and then off course the blood knights who grow stronger later,
For my Mage: I chose a highborne. Night elf. I felt though teh darnassians had magecraft only recently return, the night elves had the oldest and most powerful portrayal of the arcane arts. Not only were they the founders of the study, they also took it to heights modern day mages are still searchingfor their scraps of lost knowledge. In the returned highborne shen’dralar you entered a legacy of magecraft that continued unbroken for 10,000 years, or you are trained by one of them. There is a large chunk of hte night elf lore and story that centres around the arcane. It actually doesn’t show up much in the game till Legion where you get the MOTHERLODE, cataclysm re-introduces it tot heplayer population.
For this reason while I do have a blood elf mage, several in fact, my night elf mage is the key. Now when the nightborne came out, I would have switched to one, but that involved a faction change, would have race changed if they were on the alliance, because while the nightborne mage legacy is very similar to the highborne one, being the same culture etc, the nightborne race are particularly tailored to this in appearance. Yes the highborne are relatively on par lore wise if not ahead, but their visual presentation is way behind. Suramar though a night elven city, is also nightborne and it is now visually representative of the nightborne specifically, the arcane runes are visually enticing and the visual presentation is powerful whereas for hte highborne you don’t see it, it is only descriptive as Dire Maul was never updated, and the highborne characters never given distinctive looks.
I ddin’t switch to nightborne though, opting instead to level a warlock as nightborne. However if I hadn’t alreayd had a high level night elf, I likely would have done warlock on the void elf, mage on the nightborne, priest on the night elf, and hunter on the blood elf.
For druid: Night elf male
For Paladin: Blood elf female (for non-elf it would be human) but i mostly play elves.
For Priest: Void elf male (non elf would be Draenei holy, night elf was 2nd choice)
For Warlock: Nightborne male (non elf would be Orc)
For Warrior: Night elf female (my sentinel character)
for Rogue: Blood elf (but i wanna switch that to void elf cos I feel it’s more ideal)
for DK : can’t decide: Blood elf has far better lore representation, so it will be my choice: non-elf would be human
Shaman; i have draenei, but if I could i would race change to Dark Iron - if on the horde I feel inclined to go orc, but Zandalari is probably what I’d settle on.
Monk: Blood elf (non elf would be Pandaren ofc)